Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store the first raw value of a chunk during downsampling #1709

Merged
merged 5 commits into from
Nov 9, 2019

Commits on Nov 3, 2019

  1. store the first raw value of a chunk during downsampling

    As discussed in thanos-io#1568, storing only the last raw value
    of a chunk will lose a counter reset when:
    a) the reset occurs at a chunk boundary, and
    b) the last raw value of the earlier chunk is less than
    the first aggregated value of the later chunk.
    
    This commit stores the first raw value of a chunk during
    the initial raw aggregation, and retains it during
    subsequent aggregations. This is similar to the existing
    handling for the last raw value of a chunk.
    
    With this change, when counterSeriesIterator iterates over
    a chunk boundary, it will see the last raw value of the
    earlier chunk, then the first raw value of the later chunk,
    and then the first aggregated value of the later chunk. The
    first raw value will always be less than or equal to the
    first aggregated value, so the only difference in
    counterSeriesIterator's output will be the possible detection
    of a reset and an extra sample after the chunk boundary.
    
    Fixes: thanos-io#1568
    
    Signed-off-by: Alfred Landrum <[email protected]>
    alfred-landrum committed Nov 3, 2019
    Configuration menu
    Copy the full SHA
    75ec66c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f25a23a View commit details
    Browse the repository at this point in the history
  3. changelog for thanos-io#1709

    Signed-off-by: Alfred Landrum <[email protected]>
    alfred-landrum committed Nov 3, 2019
    Configuration menu
    Copy the full SHA
    e67e0eb View commit details
    Browse the repository at this point in the history
  4. adjust existing downsampling tests

    Signed-off-by: Alfred Landrum <[email protected]>
    alfred-landrum committed Nov 3, 2019
    Configuration menu
    Copy the full SHA
    b3bd5bd View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2019

  1. add counter aggregation comments to CounterSeriesIterator

    Signed-off-by: Alfred Landrum <[email protected]>
    alfred-landrum committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    0322a52 View commit details
    Browse the repository at this point in the history