Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/thanos/receive: avoid deadlock #1727

Merged
merged 1 commit into from
Nov 7, 2019
Merged

cmd/thanos/receive: avoid deadlock #1727

merged 1 commit into from
Nov 7, 2019

Commits on Nov 6, 2019

  1. cmd/thanos/receive: avoid deadlock 

    While debugging thanos-io#1721, I found that when thanos receive bails, there is
a race in a select statement, where the non-returning branch may be
chosen. This branch will deadlock if selected twice because the channel
reader has already exited. The way to prevent this is by checking if
we need to exit on every loop.

Signed-off-by: Lucas Servén Marín <[email protected]>
    @squat
    squat committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    66a140a View commit details
    Browse the repository at this point in the history