Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compact: add metric thanos_compactor_iterations_total #1733

Merged
merged 5 commits into from
Nov 13, 2019
Merged

compact: add metric thanos_compactor_iterations_total #1733

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6746bbb
compact: add metric thanos_compactor_iterations_total
GiedriusS Nov 8, 2019
2e79c6a
CHANGELOG: add entry
GiedriusS Nov 8, 2019
8a9a90d
compact: simplify wait check
GiedriusS Nov 8, 2019
742b451
cmd: thanos: compact: remove wait check
GiedriusS Nov 8, 2019
c8e88c1
CHANGELOG: add period
GiedriusS Nov 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ We use *breaking* word for marking changes that are not backward compatible (rel
- [#1573](https://github.com/thanos-io/thanos/pull/1573) `AliYun OSS` object storage, see [documents](docs/storage.md#aliyun-oss) for further information.
- [#1680](https://github.com/thanos-io/thanos/pull/1680) Add a new `--http-grace-period` CLI option to components which serve HTTP to set how long to wait until HTTP Server shuts down.
- [#1712](https://github.com/thanos-io/thanos/pull/1712) Rename flag on bucket web component from `--listen` to `--http-address` to match other components.
- [#1733](https://github.com/thanos-io/thanos/pull/1733) New metric `thanos_compactor_iterations_total` on Thanos Compactor which shows the number of successful iterations
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nit: add a period at the end here to keep them all full sentences.


### Fixed

Expand Down
8 changes: 8 additions & 0 deletions cmd/thanos/compact.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,10 +168,17 @@ func runCompact(
Name: "thanos_compactor_retries_total",
Help: "Total number of retries after retriable compactor error",
})
iterations := prometheus.NewCounter(prometheus.CounterOpts{
Name: "thanos_compactor_iterations_total",
Help: "Total number of iterations that were executed successfully",
})
halted.Set(0)

reg.MustRegister(halted)
reg.MustRegister(retried)
if wait {
GiedriusS marked this conversation as resolved.
Show resolved Hide resolved
reg.MustRegister(iterations)
}

downsampleMetrics := newDownsampleMetrics(reg)

Expand Down Expand Up @@ -313,6 +320,7 @@ func runCompact(
return runutil.Repeat(5*time.Minute, ctx.Done(), func() error {
err := f()
if err == nil {
iterations.Inc()
return nil
}

Expand Down