Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use block.MetaFetcher in Compactor. #1937

Merged
merged 1 commit into from
Jan 6, 2020
Merged

Conversation

bwplotka
Copy link
Member

@bwplotka bwplotka commented Jan 3, 2020

Fixes: #1335
Fixes: #1919
Fixes: #1300

Depends on #1934

Changes

  • Clean up of meta files are now started only if block which is being uploaded is older than 2 days (only a mitigation).
  • Blocks without meta.json are handled properly for all compactor phases.
  • Prepare for future implementation of https://thanos.io/proposals/201901-read-write-operations-bucket.md/
  • Added metric for partialUploadAttempt deletions and delayed it.
  • More tests.

Signed-off-by: Bartlomiej Plotka [email protected]

Verification

  • Unit tests + e2e tests.

@bwplotka bwplotka changed the base branch from meta-syncer to master January 6, 2020 12:16
Fixes: #1335
Fixes: #1919
Fixes: #1300

* Clean up of meta files are now started only if block which is being uploaded is older than 2 days (only a mitigation).
* Blocks without meta.json are handled properly for all compactor phases.
* Prepare for future implementation of https://thanos.io/proposals/201901-read-write-operations-bucket.md/
* Added metric for partialUploadAttempt deletions and delayed it.
* More tests.


Signed-off-by: Bartlomiej Plotka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants