Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cut 0.10.1 #2035

Merged
merged 3 commits into from
Jan 24, 2020
Merged

Cut 0.10.1 #2035

merged 3 commits into from
Jan 24, 2020

Conversation

bwplotka
Copy link
Member

@bwplotka bwplotka commented Jan 23, 2020 •
edited
Loading

@GiedriusS reverted the fix metric name regression in examples as they are really ONLY examples, so no point in adding them to patch release IMO (:

yeya24 and others added 2 commits January 23, 2020 17:32
@yeya24 @bwplotka
Fix invalid start/end params in series api (#2015)
b373ea9 
* fix invalid start/end params in series api

Signed-off-by: yeya24 <[email protected]>

* add testcase for serieslabels time range

Signed-off-by: yeya24 <[email protected]>
@bwplotka
Revert "Fix revert metric name regression (#2005)"
d9dc541 
This reverts commit 7d16852.
@bwplotka bwplotka force-pushed the cut-0.10.1 branch 2 times, most recently from bc49895 to 324a665 Compare January 23, 2020 16:54
@brancz
Copy link
Member

brancz commented Jan 23, 2020

I'd be ok with keeping the mixin part of releases, but don't feel too strongly.

@metalmatze
Copy link
Contributor

Having the mixin as part of releases would definitely elevate their importance and thus hopefully increase their quality. Afterall those alerts are what people are going to rely on moving forward.

@bwplotka
Copy link
Member Author

Why? No one look on those on release branch - everyone do that on the master, right 🤔

@bwplotka
Cut release 0.10.1
4a97941 
Signed-off-by: Bartlomiej Plotka <[email protected]>
@brancz
Copy link
Member

brancz commented Jan 23, 2020

We tend to use the same mixin version of etcd, ceph, etc. as the version of the software itself. I feel it would be useful to version along, then we can try to do changed to the mixin whenever we do changes on master, that way it's easy to know which mixin is compatible with which version.

squat
squat reviewed Jan 23, 2020
View reviewed changes
VERSION
@@ -1 +1 @@
0.10.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:p

squat
squat approved these changes Jan 23, 2020
View reviewed changes
Copy link
Member

@squat squat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@bwplotka bwplotka merged commit bdcc358 into release-0.10 Jan 24, 2020
@bwplotka bwplotka deleted the cut-0.10.1 branch January 24, 2020 06:57
bwplotka added a commit that referenced this pull request Jan 24, 2020
@bwplotka
Cut 0.10.1 (#2035)
19a9885 
Signed-off-by: Bartlomiej Plotka <[email protected]>
bwplotka added a commit that referenced this pull request Jan 24, 2020
@bwplotka
Cut 0.10.1 (#2035) (#2037)
49b67e7 
Signed-off-by: Bartlomiej Plotka <[email protected]>
@bwplotka
Copy link
Member Author

Fair points @brancz @metalmatze let's touch it on our Thanos sync. We need to decide then if e.g we make a mistake and discrepancy between mixin and code appear, will it require patch release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squat squat squat approved these changes

@GiedriusS GiedriusS Awaiting requested review from GiedriusS

@brancz brancz Awaiting requested review from brancz

@povilasv povilasv Awaiting requested review from povilasv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bwplotka @brancz @metalmatze @squat @yeya24