-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mixin, docs: Rename Compact -> Compactor #2065
Conversation
Signed-off-by: Kemal Akkoyun <[email protected]>
Signed-off-by: Kemal Akkoyun <[email protected]>
examples/alerts/alerts.yaml
Outdated
@@ -3,23 +3,23 @@ groups: | |||
rules: | |||
- alert: ThanosCompactorMultipleCompactsAreRunning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it better to use ThanosCompactorMultipleCompactorsAreRunning
@@ -12,7 +12,7 @@ | |||
{ | |||
alert: 'ThanosCompactorMultipleCompactsAreRunning', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
Signed-off-by: Kemal Akkoyun <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change LGTM. But I am still confused about what should we change. Should we also rename the metrics like thanos_compact_group_compactions_failures_total
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Yes, it's tricky @yeya24
Ideally we should change it, but it's super distracting change for users as it can fail in hidden way. So for now we postpone metrics, command, and API changes.
This PR renames
compact
tocompactor
in mixin and docs.As discussed in #1871
Changes
Verification
make examples
make example-rules-lint
make docs
make check-docs