Updated to golang v1.14.2

[rnaveiras]

• I added CHANGELOG entry for this change.
• Change is not relevant to the end-user.

Changes

• Update golang to 1.14.2
• Generate thanos-ci:go1.14.2-node
  This is a manual process that requires one of the maintainers to run the following:

make docker-ci DOCKER_CI_TAG=go1.14.2-node

Sadly circleci/golang:1.14.0 is not yet available, so this PR would be on hold until it becomes available, hopefully sometime in the next few days.

Rationale

Go 1.14 highlights:

• Embedding interfaces with overlapping method sets
• Improved defer performance
• Goroutines are asynchronously preemptible
• The page allocator is more efficient
• Internal timers are more efficient

Go 1.14 Announce
Go 1.14 Full Release notes
Go 1.14.1 Fixes

[bwplotka]

Amazing, thanks!

I have pushed the image. I think it's important to add a changelog for this. We do that as language version is an important change (e.g affects performance).

Curious, any particular reason for moving to new Go? (: It's a good idea, just curious.

Also, I think we are missing a couple of places. Those are documented here: https://thanos.io/contributing/how-to-change-go-version.md/ Can you double-check?

[bwplotka]

v0.4.0: digest: sha256:7a97f423ecfe6dba4e16480559277e101631af79b19cc010f3082e93befc06e9 size: 4318

[bwplotka]

Github actions/go is not yet updated?

[bwplotka]

It looks like it should work, but maybe worth to put an issue on https://github.com/actions/setup-go/

[rnaveiras]

It looks like it should work, but maybe worth to put an issue on https://github.com/actions/setup-go/

I think the issue is that 1.14.0 is advertised as 1.14 preventing being able to match exactly https://github.com/actions/setup-go/blob/master/src/installer.ts#L79-L84

[rnaveiras]

We're going to need prometheus/golang-builder#85 so the cross-build-check can run successfully.

[rnaveiras]

Curious, any particular reason for moving to new Go? (: It's a good idea, just curious.

There is a lot of improvements that could provide some performance gains to the project. e.g. improved defer performance and goroutines are asynchronously preemptible.

I update the description of the PR with a section about the changes included in golang 1.14

[rnaveiras]

@bwplotka I was double-checking the image quay.io/thanos/thanos-ci:v0.4.0 and it doesn't look correct to me.

This image is built from Dockerfile.thanos-ci which requires circleci/golang:1.14.0 that is not published yet. Did you build the image from master?

$ docker run -it quay.io/thanos/thanos-ci:v0.4.0 go version
go version go1.13.6 linux/amd64

[bwplotka]

I ran it from your PR and it was built (I think) from circleci/golang:1.14.0.... ;p so that's interesting. Maybe some previous version of your PR did not update circleci one? Or I might mess something. Anyway, retrying now from your branch 100% (:

[bwplotka]

Step 1/3 : FROM circleci/golang:1.14.0
manifest for circleci/golang:1.14.0 not found: manifest unknown: manifest unknown
make: *** [Makefile:264: docker-ci] Error 1

Ok now it makes sense...

[bwplotka]

I guess we need to.. wait?

[bwplotka]

Before we merge it: golang/go#37465 (:

[rnaveiras]

Step 1/3 : FROM circleci/golang:1.14.0
manifest for circleci/golang:1.14.0 not found: manifest unknown: manifest unknown
make: *** [Makefile:264: docker-ci] Error 1

Ok now it makes sense...

circleci/golang:1.14.0 is now available.

[GiedriusS]

@rnaveiras Care to rebase this on master? @bwplotka this is crucial for us to have not just because of the various improvements to Go in general but also because now go vet catches when %w is used not in fmt.Errorf. So, with this update we could have avoided the recent problems with error wrapping that were "done" with github.com/pkg/errors.Errorf (for context: golang/go#37792).

EDIT: I see we are still waiting on prometheus/golang-builder#85 😢

[rnaveiras]

I rebase the PR and updated to golang 1.14.1 which has been released with the following fixes Go 1.14.1 Fixes

[rnaveiras]

prometheus/golang-builder#85 has been merged after bumped it to v1.14.1 as well.

[rnaveiras]

golang/go#37436 has been closed. More info here https://github.com/golang/go/wiki/LinuxKernelSignalVectorBug

[GiedriusS]

Before we merge it: golang/go#37465 (:

I believe we are still waiting on this but other projects have upgraded already. @bwplotka how did you find this ticket? 😄

[bwplotka]

I would say let's wait until we figure out this: #2213

WDYT?

[bwplotka]

OK, I think with release candidate in the process we can update to Go 1.14.2 slowly (:

[rnaveiras]

@bwplotka I updated this PR to go 1.14.2. Could you do the honours and rebuild the ci image from this branch, please?

make docker-ci DOCKER_CI_TAG=v0.4.0

[bwplotka]

Will do, chasing some other bugs now ):

[GiedriusS]

Thank you, Bartek, for pushing the new image. AFAICT this should be good to go, no? 🎉

[bwplotka]

Did I? ;p

[bwplotka]

I don't remember... let's figure it out

[bwplotka]

What about naming tags based on what go version?

[bwplotka]

Yea it's wrong:

docker run --rm -it quay.io/thanos/thanos-ci:v0.4.0 go version
go version go1.13.6 linux/amd64

[bwplotka]

Building

# Available from https://hub.docker.com/r/circleci/golang/
FROM circleci/golang:1.14.2-node

ENV GOBIN=/go/bin

COPY tmp/bin ${GOBIN}

as quay.io/thanos/thanos-ci:go1.14.2-node

We need node for @prmsrswt React work. Can we update PR? 🤗

[bwplotka]

Image built:

make docker-ci DOCKER_CI_TAG=go1.14.2-node
>>GOBIN=/home/bwplotka/Repos/thanos/.bin
# Copy all to tmp local dir as this is required by docker.
Sending build context to Docker daemon  18.11GB
Step 1/3 : FROM circleci/golang:1.14.2-node
1.14.2-node: Pulling from circleci/golang
7e2b2a5af8f6: Pull complete
09b6f03ffac4: Pull complete
dc3f0c679f0f: Pull complete
fd4b47407fc3: Pull complete
836e4bd1f603: Pull complete
e19b4668dc6d: Pull complete
edd84f708090: Pull complete
02ba946cc36a: Pull complete
9db7d87a7472: Pull complete
a767ea6ae427: Pull complete
d1cf6bf4b66a: Pull complete
2afb37b68133: Pull complete
bb741a7b91dc: Pull complete
5c4495464a37: Pull complete
ec84306386f1: Pull complete
4983f4c73979: Pull complete
6be70d555f1f: Pull complete
13712da9f96f: Pull complete
18911cfb2c2e: Pull complete
433a33087297: Pull complete
7d4a076755d9: Pull complete
Digest: sha256:6ae50592b03ab95ea521113902d079203f740433cf237577044607b9934a538e
Status: Downloaded newer image for circleci/golang:1.14.2-node
 ---> 7b7d9cf9aa63
Step 2/3 : ENV GOBIN=/go/bin
 ---> Running in 2cf94f284c59
Removing intermediate container 2cf94f284c59
 ---> 0ee15238243b
Step 3/3 : COPY tmp/bin ${GOBIN}
 ---> 8131a4e2d14f
Successfully built 8131a4e2d14f
Successfully tagged thanos-ci:latest
>> pushing thanos-ci image
The push refers to repository [quay.io/thanos/thanos-ci]
50bcdc9b20ea: Pushed
5f1507d1187e: Pushed
9c0f490b7301: Pushed
ddefbb6afd50: Pushed
63e3127c5db0: Pushed
cb89941953ea: Pushed
f43c6d65b121: Pushed
bccade8cbab4: Pushed
1fdb87d0344a: Pushed
64e1c554adec: Pushed
f8dc9370fec2: Pushed
839bbb947445: Pushed
76c216da6cae: Pushed
232bc0d817ca: Pushed
12e878c89e55: Pushed
feae5ce26f02: Pushed
29a23d067e48: Pushed
1af88e92b20b: Pushed
d35c5bda4793: Pushed
a3c1026c6bcc: Pushed
f1d420c2af1a: Pushed
461719022993: Pushed
go1.14.2-node: digest: sha256:8d0363f6d01698bf360c4af4c789ba8cf35f6a01034ac0c3adfe25be5bca4722 size: 4949

[bwplotka]

not sure how to use node one here (:

[rnaveiras]

What version of node do we need here? and yarn?

[bwplotka]

cc @prmsrswt

[bwplotka]

Not a blocker I guess.

[onprem]

I don't think we need node here. It doesn't use node and yarn to build the React UI, rather it uses the bindata.go file to get pre-compiled react assets.

[bwplotka]

LGTM, just change log 🎉

[bwplotka]

This needs to be in unreleased, can update your PR if you don't mind (:

[bwplotka]

Actually will wait for you, no rush (:

I am adding requirements for our tools to be on go 1.14, that's why want to finalize this PR before next release ! (:

[rnaveiras]

I updated the changelog :)

[bwplotka]

Amazing! Thanks 💪