query: support store config file

[eswdd]

Closes #977

• I added CHANGELOG entry for this change.
• Change is not relevant to the end user.

Changes

This change adds support for reading stores from an external configuration file, with TLS and file SD configuration variable between sets of stores. The configuration file allows specification of one or more configurations in a similar manner to #1939 and #1982 . Have decided to mandate naming the configurations so that we can label metrics with these names since the primary use case driving this seems to be TLS vs non-TLS and the feeling around our team is that we'd like to see metrics split along these lines.

It is backwards compatible with existing flags for specifying stores, TLS and file SD.

Verification

e2e tests have been updated to use the external store config file.

[bwplotka]

Nice! Marking this as higher priority, would be nice to have review of this.

Can you mark this un-wip when ready for review?

cc @krasi-georgiev and @s-urbaniak , @simonpasquier for some help in review (:

[eswdd]

Yup. Will be working on it later today or this evening.

…

On Tue, 10 Mar 2020, 11:36 Bartlomiej Plotka, ***@***.***> wrote: Nice! Marking this as higher priority, would be nice to have review of this. Can you mark this un-wip when ready for review? cc @krasi-georgiev <https://github.com/krasi-georgiev> and @s-urbaniak <https://github.com/s-urbaniak> , @simonpasquier <https://github.com/simonpasquier> for some help in review (: — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2226?email_source=notifications&email_token=AAMTFG3XHEISI66JLQXUMTDRGYQ4XA5CNFSM4LDJXC32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOLBZNY#issuecomment-597040311>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAMTFG5MXQHEOU6YRPDYQT3RGYQ4XANCNFSM4LDJXC3Q> .

[eswdd]

@s-urbaniak have implemented all the suggestions, PTAL

[s-urbaniak]

For me this is looking great, thank you! 🎉 If there is a last nit, I would love to see some unmarshaling test (especially with the DefaultConfig handling) in pkg/store/config.go.

else this LGTM

Leaving the final pair of eyes to @bwplotka

[bwplotka]

Sorry for lag, let's wait until release is done... we are working heavily on it, then I will look on it closely, promise (:

Let's rebase, but I think rebase can wait until the merge release-0.12 -> master will happen. It might introduce some conflicts anyway.

Thanks @eswdd for patience!

[eswdd]

@bwplotka sorry, was off last week, so only just seen this - would have wanted to get this into the release but I guess too late now. When do you expect to cut the next release?

[simonpasquier]

According to the release planning, the first RC of v0.13.0 is slated for the 13th of May.

[bwplotka]

Let's get back to this... can you rebase @eswdd ?

[bwplotka]

It's huge change plus lots of things changes since last rebase, so unlikely to get in 0.13 ):

[amrmahdi]

Thanks @eswdd for this change, very much needed.
@bwplotka we are at 0.14.0 train now, would this make it to 0.14.0 ?

[bwplotka]

Sorry for huge delay on this. Let's get back to this. We might have more time this week! (: (PromCon was last week).

Do you mind reading?

[stale]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[s-urbaniak]

@bwplotka i think this is still useful, PTAL :)

[bwplotka]

We need rebase 🤔

[stale]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[markmsmith]

FWIW, I'm still interested in this. Hopefully the original author can check in before the stale bot kills it.

[stale]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[markmsmith]

Is this still blocked on a reabase from @eswdd ?

[stale]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.