Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Prometheus to latest master and reflect changes #2748

Merged
merged 2 commits into from
Jun 11, 2020

Conversation

kakkoyun
Copy link
Member

@kakkoyun kakkoyun commented Jun 10, 2020

Signed-off-by: Kemal Akkoyun [email protected]

  • I added CHANGELOG entry for this change.

Changes

Verification

  • make build
  • make test-local

@kakkoyun kakkoyun requested a review from pracucci June 10, 2020 08:58
@kakkoyun kakkoyun marked this pull request as ready for review June 10, 2020 08:58
@kakkoyun kakkoyun requested a review from bwplotka June 10, 2020 08:58
Signed-off-by: Kemal Akkoyun <[email protected]>
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

This also fixed the correctness bug I believe @pracucci (:

@bwplotka bwplotka merged commit 48ee1f8 into thanos-io:master Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants