Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: Bump Prometheus to current latest #2814

Merged
merged 3 commits into from
Jun 29, 2020
Merged

Conversation

brancz
Copy link
Member

@brancz brancz commented Jun 29, 2020

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Bump TSDB.

Verification

Tests.

@thanos-io/thanos-maintainers

This change is necessary due to the Prometheus bump, which down-scopes
the interface required for the rule manager to replay ALERT_FOR_STATE.

Signed-off-by: Frederic Branczyk <[email protected]>
@GiedriusS
Copy link
Member

Does this contain some important fixes for our users?

@brancz
Copy link
Member Author

brancz commented Jun 29, 2020

Mainly performance improvements, without running it ourselves we don't know how significant those are though. We run latest Thanos in prod all the time, so we want to just get into the habit of bumping TSDB more often so we avoid making big jumps.

@brancz
Copy link
Member Author

brancz commented Jun 29, 2020

Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bwplotka
Copy link
Member

Looks like a valid test failure @brancz

It's because in tests we are using label values which are not sorted now, we should use SortedLabelValues instead 🤗

Worth to check our TSDB method we use in StoreAPI for TSDB impl, we probably need to sort to be compliant. (if we want)

@brancz
Copy link
Member Author

brancz commented Jun 29, 2020

I'm not sure what the consequence of this is, I haven't followed those changes very closely on TSDB. From what I can tell sorted LabelValues is not exposed on the storage interfaces though so I'm not sure how to call them explicitly. Suggestions?

Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@brancz
Copy link
Member Author

brancz commented Jun 29, 2020

Couldn't figure out how to re-run netlify jobs, so re-triggered by amending last commit.

@bwplotka
Copy link
Member

We can ignore netlify, they have some incident

@brancz brancz merged commit e24ce43 into thanos-io:master Jun 29, 2020
@brancz brancz deleted the bump-prom branch June 29, 2020 16:18
paulfantom added a commit to paulfantom/thanos that referenced this pull request Jul 9, 2020
* upstream/release-0.14: (46 commits)
  Cut release v0.14.0-rc.1 (thanos-io#2853)
  Query: correctly marshal errors to JSON and ignore if nil (thanos-io#2848)
  ci: Manually download promu in crossbuild stage (thanos-io#2828)
  Cut release v0.14.0-rc.0 (thanos-io#2826)
  Soft cut changelog on master to indicate v0.14.0 being in progress (thanos-io#2824)
  Update ThanosReceiveNoUpload to select sum == 0 (thanos-io#2819)
  receive: Added more observability, fixed leaktest, to actually check leaks ): (thanos-io#2817)
  Query: always return a string in the `lastError` field (thanos-io#2809)
  Added missing CHANGELOG entry for PR 2613 (thanos-io#2820)
  receive: Fixed small options race; Removed unused StartTime feature. (thanos-io#2816)
  go.mod: Bump Prometheus to current latest (thanos-io#2814)
  Implement CLI Flags page in React UI (thanos-io#2796)
  Improve ThanosReceiveNoUpload to only alert on current instances
  store: Preallocate output buffer when encoding postings. (thanos-io#2812)
  compact: introduce flag --block-viewer.global.sync-block-interval (thanos-io#2752)
  docs: compact: add blurb about how retention policy works (thanos-io#2808)
  Reduced memory allocations in readIndexRange() (thanos-io#2807)
  ui: Add Stores page to React UI (thanos-io#2754)
  Added Kemal to Maintainer Role; Kemal is volounteering to be next release shephard (thanos-io#2804)
  proposal: Add scalable rule storage proposal (thanos-io#2661)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants