Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query: correctly marshal errors to JSON and ignore if nil #2847

Closed
wants to merge 2 commits into from
Closed

Query: correctly marshal errors to JSON and ignore if nil #2847

wants to merge 2 commits into from

Conversation

cuotos
Copy link
Contributor

@cuotos cuotos commented Jul 6, 2020

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Fixes: #2846
Passing nil error to updateStoreStatus causes a panic. This is displayed to the user in the Stores ui when the Store is healthy

Added higher level unit test to catch this, and hopefully clarified existing test.

@cuotos cuotos closed this Jul 6, 2020
@cuotos
Copy link
Contributor Author

cuotos commented Jul 6, 2020

thought id completely message up my testing, panicked and closed this. turns out i had another instance running.... have created a new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query: /api/v1/stores panics when store is healthy - v0.14.0-rc.0
1 participant