deps/objstore: upgrade to minio-go/v7 #2970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Hellbom <[email protected]>
Signed-off-by: Alexander Hellbom <[email protected]>
Signed-off-by: Alexander Hellbom <[email protected]>
bwplotka
reviewed
Aug 3, 2020
| }).DialContext, | ||
|
|
||
| MaxIdleConns: 100, | ||
| MaxIdleConnsPerHost: 100, |
| @@ -228,7 +233,12 @@ func (b *Bucket) Iter(ctx context.Context, dir string, f func(string) error) err | |||
| dir = strings.TrimSuffix(dir, DirDelim) + DirDelim | |||
| } | |||
|
|
|||
| for object := range b.client.ListObjects(b.name, dir, false, ctx.Done()) { | |||
| opts := minio.ListObjectsOptions{ | |||
There was a problem hiding this comment.
This is used once, so we can inline (:
See: https://thanos.io/contributing/coding-style-guide.md/#avoid-defining-variables-used-only-once
| @@ -314,7 +324,7 @@ func (b *Bucket) Upload(ctx context.Context, name string, r io.Reader) error { | |||
| if size < int64(partSize) { | |||
| partSize = 0 | |||
| } | |||
| if _, err := b.client.PutObjectWithContext( | |||
| if _, err := b.client.PutObject( | |||
bwplotka
approved these changes
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
First time contributor so might need some handholding here :)
Upgraded from minio-go/v6 to minio-go/v7 and adjusted a couple functions to resolve the following issue: #2097
Example timings before (compactor):
Example timings after (compactor):
Fixes: #2097
Related: minio/minio-go#1321
Verification
Existing tests and from actual usage.
Happy to provide more information and/or add tests if necessary :)