Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: Better rounding for incoming query timestamps. #2976

Merged
merged 1 commit into from
Aug 5, 2020
Merged

Query: Better rounding for incoming query timestamps. #2976

merged 1 commit into from
Aug 5, 2020

Conversation

johncming
Copy link
Contributor

@johncming johncming commented Aug 4, 2020 •
edited
Loading

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Fixes: #2971

Use same fix like prometheus/prometheus#4941

Verification

  1. Add a test case in TestParseTime and run it.
  2. Run make via ci.

@johncming johncming marked this pull request as draft August 4, 2020 11:17
@johncming johncming changed the title query: Better rounding for incoming query timestamps. Query: Better rounding for incoming query timestamps. Aug 4, 2020
@johncming johncming mentioned this pull request Aug 4, 2020
Closed
@johncming johncming marked this pull request as ready for review August 5, 2020 03:29
onprem
onprem approved these changes Aug 5, 2020
View reviewed changes
Copy link
Member

@onprem onprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

GiedriusS
GiedriusS approved these changes Aug 5, 2020
View reviewed changes
Copy link
Member

@GiedriusS GiedriusS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@GiedriusS GiedriusS merged commit 7db0cd6 into thanos-io:master Aug 5, 2020
@bwplotka
Copy link
Member

bwplotka commented Aug 6, 2020

Thank you for so quick pr! 😻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiedriusS GiedriusS GiedriusS approved these changes

@onprem onprem onprem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

All result timestamps off by 1ms for certain floating-point input timestamps
4 participants
@johncming @bwplotka @GiedriusS @onprem