Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go version to 1.15 in go.mod #3206

Merged
merged 1 commit into from
Sep 23, 2020
Merged

Update go version to 1.15 in go.mod #3206

merged 1 commit into from
Sep 23, 2020

Conversation

mneverov
Copy link
Contributor

Signed-off-by: Max Neverov [email protected]

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

go version update was done in #3022 and go.mod file wasn't updated. Tests for reloader were failing when run with go1.14

Verification

kakkoyun
kakkoyun reviewed Sep 23, 2020
View reviewed changes
Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mneverov Could you please elaborate what fails? I wonder which feature we use specific to 1.15

@mneverov
Copy link
Contributor Author

Hi @kakkoyun ,

pkg/reloader/reloader_test.go:366:11: t.TempDir undefined (type *testing.T has no field or method TempDir)

The new feature T.TempDir() was added in #3136.

kakkoyun
kakkoyun approved these changes Sep 23, 2020
View reviewed changes
Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Alright, cool. Thanks a lot for the explanation and the contribution.

@kakkoyun kakkoyun merged commit eebb166 into thanos-io:master Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kakkoyun kakkoyun kakkoyun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mneverov @kakkoyun