Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare the v0.17.0-rc.0 release #3441

Merged
merged 1 commit into from
Nov 13, 2020

Conversation

metalmatze
Copy link
Contributor

No description provided.

@yeya24
Copy link
Contributor

yeya24 commented Nov 12, 2020

Can we include #3440 and #3431 as well? #3440 fixes a critical bug.

@metalmatze
Copy link
Contributor Author

I've rebased the branch release-0.17 outside this PR to have the latest master branch.

Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 LGTM

@metalmatze
Copy link
Contributor Author

Not sure about these links in Markdown...

@bwplotka
Copy link
Member

You can ignore those links, totally broken and flaky things. We are on it but low priority.

Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could leave katacoda tutorials for now, WDYT? Otherwise LGTM (:

@@ -1,7 +1,7 @@
#!/usr/bin/env bash

docker pull quay.io/prometheus/prometheus:v2.20.0
docker pull quay.io/thanos/thanos:v0.16.0-rc.1
docker pull quay.io/thanos/thanos:v0.17.0-rc.0
Copy link
Member

@bwplotka bwplotka Nov 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels premature to do this before the image is built & tested. This will make those tutorials to be updated sooner than image is built potentially ;p (not mentioning testing tutorials with it etc)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, this is only on the release branch though. I'll revert anyway then. :)

Copy link
Member

@bwplotka bwplotka Nov 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah you are right. Then it does not matter much (:

Signed-off-by: Matthias Loibl <[email protected]>
@metalmatze metalmatze merged commit 6bd4f71 into thanos-io:release-0.17 Nov 13, 2020
@metalmatze metalmatze deleted the release-0.17-prepare branch November 13, 2020 12:14
metalmatze added a commit to metalmatze/thanos that referenced this pull request Nov 20, 2020
metalmatze added a commit to metalmatze/thanos that referenced this pull request Nov 20, 2020
metalmatze added a commit to metalmatze/thanos that referenced this pull request Nov 20, 2020
bwplotka pushed a commit that referenced this pull request Nov 20, 2020
* Prepare the v0.17.0-rc.0 release (#3441)

Signed-off-by: Matthias Loibl <[email protected]>

* store: Enabled postings compressions by default. Removed feature flag. (#3452)

Signed-off-by: Bartlomiej Plotka <[email protected]>
Signed-off-by: Matthias Loibl <[email protected]>

* Publish v0.17.0 release (#3462)

Signed-off-by: Matthias Loibl <[email protected]>

* Set VERSION to 0.18.0-dev

Signed-off-by: Matthias Loibl <[email protected]>

* Fix changelog

Signed-off-by: Matthias Loibl <[email protected]>

* Fix bucket_test.go after rebase

Signed-off-by: Matthias Loibl <[email protected]>
Oghenebrume50 pushed a commit to Oghenebrume50/thanos that referenced this pull request Dec 7, 2020
* Prepare the v0.17.0-rc.0 release (thanos-io#3441)

Signed-off-by: Matthias Loibl <[email protected]>

* store: Enabled postings compressions by default. Removed feature flag. (thanos-io#3452)

Signed-off-by: Bartlomiej Plotka <[email protected]>
Signed-off-by: Matthias Loibl <[email protected]>

* Publish v0.17.0 release (thanos-io#3462)

Signed-off-by: Matthias Loibl <[email protected]>

* Set VERSION to 0.18.0-dev

Signed-off-by: Matthias Loibl <[email protected]>

* Fix changelog

Signed-off-by: Matthias Loibl <[email protected]>

* Fix bucket_test.go after rebase

Signed-off-by: Matthias Loibl <[email protected]>
Signed-off-by: Oghenebrume50 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants