Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

downsample: ensure consistent order #3843

Merged
merged 1 commit into from
Feb 26, 2021
Merged

downsample: ensure consistent order #3843

merged 1 commit into from
Feb 26, 2021

Commits on Feb 26, 2021

  1. downsample: ensure consistent order 

    Ensure that we have a consistent order of blocks that we are going to
downsample. `range` over maps doesn't enforce any particular order on
purpose.

This is needed for https://github.com/thanos-io/thanos/pull/3031/files.
ATM in that PR before downsampling we delete all directories which do
not match blocks ULIDs in the remote object storage. Ideally, we should
only keep around the files of a block which we are about to downsample.

It is impossible to do that properly ATM if during another iteration
we'd start from a different block. Thus, let's have a consistent order.

Signed-off-by: Giedrius Statkevičius <[email protected]>
    @GiedriusS
    GiedriusS committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    6597d4e View commit details
    Browse the repository at this point in the history