Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.*: Apply webrouteprefix on debug and metric endpoints #4471

Closed
wants to merge 12 commits into from
Closed

.*: Apply webrouteprefix on debug and metric endpoints #4471

wants to merge 12 commits into from

Commits on Apr 20, 2022

  1. Apply webrouteprefix on all endpoints 

    Signed-off-by: Will Hegedus <[email protected]>
    @wbh1
    wbh1 committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    79c0d95 View commit details
    Browse the repository at this point in the history

  2. add CHANGELOG entry 

    Signed-off-by: Will Hegedus <[email protected]>
    @wbh1
    wbh1 committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    4b0ce7b View commit details
    Browse the repository at this point in the history

  3. fix tests to account for URL prefix 

    Signed-off-by: Will Hegedus <[email protected]>
    @wbh1
    wbh1 committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    bdd8da6 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2022

  1. tests: update query tests for route prefixes 

    This adds additional endpoints that were not previously behind the routePrefix
to the testing suite and improves documentation of those tests.

Signed-off-by: Will Hegedus <[email protected]>
    @wbh1
    wbh1 committed May 8, 2022
    Configuration menu
    Copy the full SHA
    9be439f View commit details
    Browse the repository at this point in the history

  2. tests: fail on HTTP errors in checkNetworkRequests 

    This will now return errors if an HTTP error (status >= 400) is returned by the
chrome driver.

Additionally, the Chrome context is now modified to inherit the deadline from the running test suite.

Signed-off-by: Will Hegedus <[email protected]>
    @wbh1
    wbh1 committed May 8, 2022
    Configuration menu
    Copy the full SHA
    4f7bbec View commit details
    Browse the repository at this point in the history

  3. tests: add tests for routePrefix on Thanos Ruler 

    Validate that the --web.route-prefix flag adjusts expected routes.

Signed-off-by: Will Hegedus <[email protected]>
    @wbh1
    wbh1 committed May 8, 2022
    Configuration menu
    Copy the full SHA
    b81ea62 View commit details
    Browse the repository at this point in the history

  4. fix: Prefix compact's routes with routePrefix 

    Thanos Compact supports the flags for webconf, but previously was not actually doing anything with them.

Signed-off-by: Will Hegedus <[email protected]>
    @wbh1
    wbh1 committed May 8, 2022
    Configuration menu
    Copy the full SHA
    92122c6 View commit details
    Browse the repository at this point in the history

  5. feat: support all webConfig flags in Thanos Store 

    Refactors Thanos Store to use the registerFlag function to ensure it receives all
flags that are applicable to webConfig. Previously, only 3/4 were manually defined.

Signed-off-by: Will Hegedus <[email protected]>
    @wbh1
    wbh1 committed May 8, 2022
    Configuration menu
    Copy the full SHA
    e3e04fd View commit details
    Browse the repository at this point in the history

  6. fix: correctly prefix routes in Thanos Store 

    Previously, routes were not getting the value of the --web.*-prefix flags applied.

Signed-off-by: Will Hegedus <[email protected]>
    @wbh1
    wbh1 committed May 8, 2022
    Configuration menu
    Copy the full SHA
    fcfcc9a View commit details
    Browse the repository at this point in the history

Commits on May 9, 2022

  1. style: fix go-lint errors in e2e tests 

    Signed-off-by: Will Hegedus <[email protected]>
    @wbh1
    wbh1 committed May 9, 2022
    Configuration menu
    Copy the full SHA
    fc9c46a View commit details
    Browse the repository at this point in the history

  2. docs: update flags for Thanos Store 

    Signed-off-by: Will Hegedus <[email protected]>
    @wbh1
    wbh1 committed May 9, 2022
    Configuration menu
    Copy the full SHA
    47c85de View commit details
    Browse the repository at this point in the history

  3. docs: clarify changelog 

    Signed-off-by: Will Hegedus <[email protected]>
    @wbh1
    wbh1 committed May 9, 2022
    Configuration menu
    Copy the full SHA
    f18fa62 View commit details
    Browse the repository at this point in the history