Cut release 0.23.0-rc.0 #4625
Merged
Cut release 0.23.0-rc.0 #4625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwplotka
requested review from
kakkoyun,
GiedriusS,
wiardvanrij,
squat,
onprem and
bill3tt
wiardvanrij
approved these changes
Sep 1, 2021
squat
approved these changes
Sep 2, 2021
|
#4586 (comment) I suppose this needs fixing before the release :( |
|
Yup, that's a small blocker: #4586 (comment) |
bwplotka
force-pushed
the
cut-0.23-rc.0-v2
branch
from
7af94eb
to
600b723
Compare
|
rebased release branch on fixed main 💪🏽 Let's go! |
|
Do we need to mention #4421? With that PR we now pick up all of the APIs that a node exposes automatically, right? |
|
You are absolutely right I missed this. Just checked the code it does not matter indeed 💪🏽 |
|
Double checking now if this will work will old Rule/Metadata etc APIs? |
|
I think there is regression here - if someone points to old Ruler API (e.g Thanos Ruler) in |
|
I understand, but I think we can't assume that. One can roll querier without rolling other components. Adding test case and potential fix here: #4645 |
|
I might be wrong, all might be good thanks to |
Signed-off-by: Bartlomiej Plotka <[email protected]>
bwplotka
force-pushed
the
cut-0.23-rc.0-v2
branch
from
600b723
to
ee0c963
Compare
|
Addressed comment, @GiedriusS @hitanshu-mehta and confirmed all is good, no regression is there (spent ~2h on assuring that = worth it XD!). Thanks for amazing work (: |
GiedriusS
approved these changes
Sep 8, 2021
yeya24
approved these changes
Sep 8, 2021
bwplotka
added a commit
that referenced
this pull request
Oct 6, 2021
* Cut release 0.23.0-rc.0 (#4625) Signed-off-by: Bartlomiej Plotka <[email protected]> * Updated version. Signed-off-by: Bartlomiej Plotka <[email protected]> * Cut 0.23.0-rc.1 and cherry picked 3 critical commits from main. (#4684) * Sidecar: Fix process external label on promethues v2.28+ use units.Bytes config type (#4657) * Sidecar: Fix process external label when promethues v2.28+ use units.Bytes config type (#4656) Signed-off-by: hanjm <[email protected]> * E2E: Upgrade prometheus image version Signed-off-by: hanjm <[email protected]> * upgrade Prometheus dependency version to v2.30.0 (#4669) * upgrade Prometheus dependency version to v2.30.0 Signed-off-by: Ben Ye <[email protected]> * fix unit test Signed-off-by: Ben Ye <[email protected]> # Conflicts: # go.mod # go.sum * Query: Fix (*exemplarsStream).receive/(*metricMetadataStream).receive/(*targetsStreamStream).receive infinite loop when target response Unimplemented error (#4676) (#4681) Signed-off-by: hanjm <[email protected]> * Cut 0.23.0-rc.1 Signed-off-by: Bartlomiej Plotka <[email protected]> Co-authored-by: Jimmiehan <[email protected]> Co-authored-by: Ben Ye <[email protected]> * Cut 0.23.0 release. (#4697) * Endpointset: Do not use info client to obtain metadata (for now) (#4714) * Do not use info client to obtain metadata Signed-off-by: Matej Gera <[email protected]> * Update CHANGELOG. Signed-off-by: Matej Gera <[email protected]> * Comment out client.info usage Signed-off-by: Matej Gera <[email protected]> * Fix lint error Signed-off-by: Matej Gera <[email protected]> * Cutting 0.23.1 (#4718) Signed-off-by: Bartlomiej Plotka <[email protected]> * Moved tutorials Thanos versions to 0.23.1 Signed-off-by: Bartlomiej Plotka <[email protected]> * Added volounteer for shepharding, fixed VERSION. Signed-off-by: Bartlomiej Plotka <[email protected]> Co-authored-by: Jimmiehan <[email protected]> Co-authored-by: Ben Ye <[email protected]> Co-authored-by: Matej Gera <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bartlomiej Plotka [email protected]