Add series label for unhealthy index debug log #4727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: metonymic-smokey <[email protected]>
metonymic-smokey
force-pushed
the
series-label
branch
from
f163a9d
to
f252039
Compare
Signed-off-by: metonymic-smokey <[email protected]>
Signed-off-by: metonymic-smokey <[email protected]>
Signed-off-by: metonymic-smokey <[email protected]>
metonymic-smokey
force-pushed
the
series-label
branch
from
6427b06
to
be490ce
Compare
Signed-off-by: metonymic-smokey <[email protected]>
Signed-off-by: metonymic-smokey <[email protected]>
yeya24
reviewed
Oct 2, 2021
|
@yeya24 after these latest reviews, I've retained only the most essential code i.e. printing the labelset when an out of order series occurs. |
metonymic-smokey
force-pushed
the
series-label
branch
from
da57042
to
380b6cb
Compare
Signed-off-by: metonymic-smokey <[email protected]>
metonymic-smokey
force-pushed
the
series-label
branch
from
380b6cb
to
bd906fc
Compare
yeya24
reviewed
Oct 2, 2021
Signed-off-by: metonymic-smokey <[email protected]>
Signed-off-by: metonymic-smokey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: metonymic-smokey [email protected]
Fixes #4470
Changes
The debug log on compaction when an unhealthy index is found now mentions the series in the out of order index too. Earlier, only the proportion of such series was logged.
Verification