-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add capability to use custom AWS STS Endpoint #4736
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
377b723
Add configurable AWS STS Endpoint
MioOgbeni d155761
Edit Docs
MioOgbeni bc00439
Merge branch 'thanos-io:main' into main
MioOgbeni 311b308
Edit Changelog
MioOgbeni 19ecd96
Merge branch 'main' of https://github.com/MioOgbeni/thanos
MioOgbeni b19740f
Merge branch 'thanos-io:main' into main
MioOgbeni d847f0f
Merge branch 'main' into main
MioOgbeni 0373184
Fix formating
MioOgbeni c5b678c
Update CHANGELOG.md
MioOgbeni File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -84,8 +84,9 @@ type Config struct { | |
ListObjectsVersion string `yaml:"list_objects_version"` | ||
// PartSize used for multipart upload. Only used if uploaded object size is known and larger than configured PartSize. | ||
// NOTE we need to make sure this number does not produce more parts than 10 000. | ||
PartSize uint64 `yaml:"part_size"` | ||
SSEConfig SSEConfig `yaml:"sse_config"` | ||
PartSize uint64 `yaml:"part_size"` | ||
SSEConfig SSEConfig `yaml:"sse_config"` | ||
STSEndpoint string `yaml:"sts_endpoint"` | ||
} | ||
|
||
// SSEConfig deals with the configuration of SSE for Minio. The following options are valid: | ||
|
@@ -228,6 +229,7 @@ func NewBucketWithConfig(logger log.Logger, config Config, component string) (*B | |
Client: &http.Client{ | ||
Transport: http.DefaultTransport, | ||
}, | ||
Endpoint: config.STSEndpoint, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That was... easy! 🙈 |
||
}), | ||
} | ||
} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏽