Use time.RFC3339 in bucket inspect command for consistency #5114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiedriusS
reviewed
Feb 2, 2022
cmd/thanos/tools_bucket.go
Outdated
| @@ -997,8 +997,8 @@ func (t Table) Less(i, j int) bool { | |||
|
|
|||
| func compare(s1, s2 string) bool { | |||
| // Values can be either Time, Duration, comma-delimited integers or strings. | |||
| s1Time, s1Err := time.Parse("02-01-2006 15:04:05", s1) | |||
| s2Time, s2Err := time.Parse("02-01-2006 15:04:05", s2) | |||
| s1Time, s1Err := time.Parse(time.RFC1123, s1) | |||
There was a problem hiding this comment.
Good catch 😆 I'm not sure how I mixed up my copy/paste there but fixed now 🙇
Signed-off-by: Paul Traylor <[email protected]>
kfdm
force-pushed
the
bucket-inspect-time
branch
from
34f291c
to
ab87baa
Compare
Nicholaswang
pushed a commit
to Nicholaswang/thanos
that referenced
this pull request
Mar 6, 2022
…#5114) Signed-off-by: Paul Traylor <[email protected]> Signed-off-by: Nicholaswang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Most places in thanos use RFC3339 for formatting, but I noticed that
thanos tools bucket inspecthad the format hardcoded.Verification
Built the thanos binary and tried the inspect command to verify the output