compact: Add optional flag to disable downsampling. #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwplotka
changed the title
domgreen
reviewed
Sep 13, 2018
| @@ -44,6 +44,11 @@ func registerCompact(m map[string]setupFunc, app *kingpin.Application, name stri | |||
| wait := cmd.Flag("wait", "Do not exit after all compactions have been processed and wait for new work."). | |||
| Short('w').Bool() | |||
|
|
|||
| // TODO(bplotka): Remove this flag once https://github.com/improbable-eng/thanos/issues/297 is fixed. | |||
| disableDownsampling := cmd.Flag("debug.disable-downsampling", "Disables downsampling. This is not recommended " + | |||
There was a problem hiding this comment.
why is this not compact.disable-downsampling? Seems to be the pattern elsewhere in the codebase ... see query.
There was a problem hiding this comment.
because it's debug only and should be set only when you know consequences.
cmd/thanos/compact.go
Outdated
| // We run two passes of this to ensure that the 1h downsampling is generated | ||
| // for 5m downsamplings created in the first run. | ||
| level.Info(logger).Log("msg", "start first pass of downsampling") | ||
| // TODO(bplotka): Remove "disableCompaction" once https://github.com/improbable-eng/thanos/issues/297 is fixed. |
There was a problem hiding this comment.
wrong flag disableDownsampling?
bwplotka
force-pushed
the
compact-optional-downs
branch
from
fa91641
to
6dab67d
Compare
Fixes #297 Signed-off-by: Bartek Plotka <[email protected]>
bwplotka
force-pushed
the
compact-optional-downs
branch
from
6dab67d
to
645f30c
Compare
|
PTAL @domgreen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #297
PTAL @drax68