Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compact.md #5620

Merged
merged 4 commits into from
Aug 27, 2022
Merged

Update compact.md #5620

merged 4 commits into from
Aug 27, 2022

Conversation

tusharxoxoxo
Copy link
Contributor

Signed-off-by: Tushar Dahiya [email protected]

fixed 🚩 Grammatical Error

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Verification

@tusharxoxoxo
Copy link
Contributor Author

can someone tell why documentation check failed

Copy link
Collaborator

@matej-g matej-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job! It's nice to get some clean up in the docs! I added few smaller suggestions 👌

docs/components/compact.md Show resolved Hide resolved
docs/components/compact.md Outdated Show resolved Hide resolved
docs/components/compact.md Outdated Show resolved Hide resolved
docs/components/compact.md Outdated Show resolved Hide resolved
docs/components/compact.md Outdated Show resolved Hide resolved
docs/components/compact.md Outdated Show resolved Hide resolved
docs/components/compact.md Outdated Show resolved Hide resolved
docs/components/compact.md Outdated Show resolved Hide resolved
docs/components/compact.md Outdated Show resolved Hide resolved
matej-g
matej-g previously approved these changes Aug 22, 2022
Copy link
Collaborator

@matej-g matej-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙌

Copy link
Contributor

@fpetkovski fpetkovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits

docs/components/compact.md Outdated Show resolved Hide resolved
docs/components/compact.md Outdated Show resolved Hide resolved
@Rahulkumar2002
Copy link
Contributor

Rahulkumar2002 commented Aug 23, 2022

can someone tell why documentation check failed

How do you fixed doc/Documentation test in PR ? My doc check also getting failed in PR.

@tusharxoxoxo
Copy link
Contributor Author

is it done or more work to be done on this??

Copy link
Contributor Author

@tusharxoxoxo tusharxoxoxo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fine

Copy link
Contributor

@fpetkovski fpetkovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

tusharxoxoxo and others added 4 commits August 27, 2022 13:37
Signed-off-by: Tushar Dahiya <[email protected]>
Co-authored-by: Matej Gera <[email protected]>
Signed-off-by: Tushar Dahiya <[email protected]>
Co-authored-by: Filip Petkovski <[email protected]>
Signed-off-by: Tushar Dahiya <[email protected]>
Co-authored-by: Filip Petkovski <[email protected]>
Signed-off-by: Tushar Dahiya <[email protected]>
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bwplotka bwplotka merged commit 544d67a into thanos-io:main Aug 27, 2022
prajain12 pushed a commit to prajain12/thanos that referenced this pull request Sep 6, 2022
* Update compact.md

Signed-off-by: Tushar Dahiya <[email protected]>

* Apply suggestions from code review

Co-authored-by: Matej Gera <[email protected]>
Signed-off-by: Tushar Dahiya <[email protected]>

* Apply suggestions from code review

Co-authored-by: Filip Petkovski <[email protected]>
Signed-off-by: Tushar Dahiya <[email protected]>

* Apply suggestions from code review

Co-authored-by: Filip Petkovski <[email protected]>
Signed-off-by: Tushar Dahiya <[email protected]>

Signed-off-by: Tushar Dahiya <[email protected]>
Co-authored-by: Matej Gera <[email protected]>
Co-authored-by: Filip Petkovski <[email protected]>
Signed-off-by: Prakul Jain <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants