-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cut 0.28.1 #5757
Cut 0.28.1 #5757
Conversation
b083ea4
to
e27f50d
Compare
Umm, I am not sure how should I fix the DCO issue.
Should I signed off for |
Can't we just force it to pass? |
This change is small enough, I don't really see a need to cut a release candidate. Maybe just directly release 0.28.1. |
Hmmm seems like there is a residual email from my previous company that is messing things up. Added the reddit email to DCO maybe this will fix things? |
Unfortunately we seem to have issues with DCO all the time, even though all the commits are properly signed, not the first time during release. We should be fine skipping it IMHO if we manually verify the commits are signed. Otherwise agreed with @SuperQ, this might be fine without RC given it's a single small fix. |
Cool, I will skip the RC and cut the release. |
The DCO failure is because the commit has to be signed by the commiter. 5b5cdc9 was signed by @davinci26, but commited by @yeya24, so it needs to be signed also by @yeya24. |
Ah makes sense, because it's not the same as the original commit that was merged into main |
* Updates minio-go to v7.0.37 from v7.0.32 fixes #5701 Changelog: minio/minio-go@v7.0.32...v7.0.37 Signed-off-by: Sotiris Nanopoulos <[email protected]> * Adds changelog entry Signed-off-by: Sotiris Nanopoulos <[email protected]> Signed-off-by: Sotiris Nanopoulos <[email protected]> Signed-off-by: Ben Ye <[email protected]>
Signed-off-by: Ben Ye <[email protected]> add line Signed-off-by: Ben Ye <[email protected]>
e27f50d
to
cbbcf66
Compare
Thanks @douglascamata, this works! |
Still says |
Signed-off-by: Ben Ye <[email protected]>
8ed97ea
to
101a4bf
Compare
@SuperQ Thanks, mind taking another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Cut 0.28.0-rc.0 (#5632) * cut 0.28.0-rc.0 Signed-off-by: Ben Ye <[email protected]> * address review comments Signed-off-by: Ben Ye <[email protected]> * mention experimental/hidden features Signed-off-by: Ben Ye <[email protected]> * include #5607 in changelog Signed-off-by: Ben Ye <[email protected]> Signed-off-by: Ben Ye <[email protected]> * cut v0.28.0 (#5647) Signed-off-by: Ben Ye <[email protected]> Signed-off-by: Ben Ye <[email protected]> * Cut 0.28.1 (#5757) * Updates minio-go to v7.0.37 from v7.0.32 (#5702) * Updates minio-go to v7.0.37 from v7.0.32 fixes #5701 Changelog: minio/minio-go@v7.0.32...v7.0.37 Signed-off-by: Sotiris Nanopoulos <[email protected]> * Adds changelog entry Signed-off-by: Sotiris Nanopoulos <[email protected]> Signed-off-by: Sotiris Nanopoulos <[email protected]> Signed-off-by: Ben Ye <[email protected]> * update changelog and version Signed-off-by: Ben Ye <[email protected]> add line Signed-off-by: Ben Ye <[email protected]> * update version to 0.28.1 Signed-off-by: Ben Ye <[email protected]> Signed-off-by: Sotiris Nanopoulos <[email protected]> Signed-off-by: Ben Ye <[email protected]> Co-authored-by: Sotiris Nanopoulos <[email protected]> Signed-off-by: Ben Ye <[email protected]> Signed-off-by: Sotiris Nanopoulos <[email protected]> Signed-off-by: Ben Ye <[email protected]> Co-authored-by: Ben Ye <[email protected]> Co-authored-by: Sotiris Nanopoulos <[email protected]>
* Cut 0.28.0-rc.0 (thanos-io#5632) * cut 0.28.0-rc.0 Signed-off-by: Ben Ye <[email protected]> * address review comments Signed-off-by: Ben Ye <[email protected]> * mention experimental/hidden features Signed-off-by: Ben Ye <[email protected]> * include thanos-io#5607 in changelog Signed-off-by: Ben Ye <[email protected]> Signed-off-by: Ben Ye <[email protected]> * cut v0.28.0 (thanos-io#5647) Signed-off-by: Ben Ye <[email protected]> Signed-off-by: Ben Ye <[email protected]> * Cut 0.28.1 (thanos-io#5757) * Updates minio-go to v7.0.37 from v7.0.32 (thanos-io#5702) * Updates minio-go to v7.0.37 from v7.0.32 fixes thanos-io#5701 Changelog: minio/minio-go@v7.0.32...v7.0.37 Signed-off-by: Sotiris Nanopoulos <[email protected]> * Adds changelog entry Signed-off-by: Sotiris Nanopoulos <[email protected]> Signed-off-by: Sotiris Nanopoulos <[email protected]> Signed-off-by: Ben Ye <[email protected]> * update changelog and version Signed-off-by: Ben Ye <[email protected]> add line Signed-off-by: Ben Ye <[email protected]> * update version to 0.28.1 Signed-off-by: Ben Ye <[email protected]> Signed-off-by: Sotiris Nanopoulos <[email protected]> Signed-off-by: Ben Ye <[email protected]> Co-authored-by: Sotiris Nanopoulos <[email protected]> Signed-off-by: Ben Ye <[email protected]> Signed-off-by: Sotiris Nanopoulos <[email protected]> Signed-off-by: Ben Ye <[email protected]> Co-authored-by: Ben Ye <[email protected]> Co-authored-by: Sotiris Nanopoulos <[email protected]> Signed-off-by: utukj <[email protected]>
Changes
It is a little bit late now but the goal of this pr is to cut
v0.28.1-rc.0
to mainly brings in https://github.com/thanos-io/thanos/pull/5702/files to fix panic due to minio.Verification