Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compact: Enable metadata cache #5763

Merged

Conversation

igorwwwwwwwwwwwwwwwwwwww
Copy link
Contributor

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

  • Enables metadata cache, it will be placed in data-dir/meta-syncer

Verification

TBD.

@igorwwwwwwwwwwwwwwwwwwww
Copy link
Contributor Author

I wasn't sure if there's some consistency reasons for disabling this cache. But given how frequently we sync in the compactor, I think it makes sense to use the cache if possible.

Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@matej-g matej-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@matej-g matej-g merged commit 633c5b2 into thanos-io:main Oct 7, 2022
utukJ pushed a commit to utukJ/thanos that referenced this pull request Oct 13, 2022
Signed-off-by: Igor Wiedler <[email protected]>

Signed-off-by: Igor Wiedler <[email protected]>
Signed-off-by: utukj <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants