Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement lazy retrieval of series from object store. #5837

Merged
merged 14 commits into from
Nov 28, 2022
Merged

Implement lazy retrieval of series from object store. #5837

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
9ed9a91
Implement lazy retrieval of series from object store.
fpetkovski Oct 28, 2022
ca12644
Add batching
fpetkovski Oct 28, 2022
1c5886b
Preload series in batches
fpetkovski Oct 30, 2022
f1e9538
Emit proper stats
fpetkovski Oct 30, 2022
e1327dc
Extract block series client
fpetkovski Oct 31, 2022
6a8b06b
Fix CI
fpetkovski Oct 31, 2022
89d237f
Address review comments
fpetkovski Nov 1, 2022
774016a
Use emptyPostingsCount in lazyRespSet
fpetkovski Nov 4, 2022
30143bc
Reuse chunk metas
fpetkovski Nov 5, 2022
f2c4ecc
Avoid overallocating for small responses
fpetkovski Nov 6, 2022
8946647
Add metric for chunk fetch time
fpetkovski Nov 12, 2022
cbc3d23
Regroup imports
fpetkovski Nov 13, 2022
25ed544
Change counter to uint64
fpetkovski Nov 14, 2022
57a3124
Merge branch 'main' into lazy-bucket-store
fpetkovski Nov 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ kube/.minikube
data/
test/e2e/e2e_*

# Ignore benchmarks dir.
benchmarks/

# Ignore promu artifacts.
/.build
/.release
Expand Down
2 changes: 2 additions & 0 deletions cmd/thanos/query.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ import (

v1 "github.com/prometheus/prometheus/web/api/v1"
"github.com/thanos-community/promql-engine/engine"

apiv1 "github.com/thanos-io/thanos/pkg/api/query"
"github.com/thanos-io/thanos/pkg/compact/downsample"
"github.com/thanos-io/thanos/pkg/component"
Expand Down Expand Up @@ -97,6 +98,7 @@ func registerQuery(app *extkingpin.App) {

queryTimeout := extkingpin.ModelDuration(cmd.Flag("query.timeout", "Maximum time to process query by query node.").
Default("2m"))

promqlEngine := cmd.Flag("query.promql-engine", "PromQL engine to use.").Default(string(promqlEnginePrometheus)).
Enum(string(promqlEnginePrometheus), string(promqlEngineThanos))

Expand Down
6 changes: 6 additions & 0 deletions cmd/thanos/store.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ package main
import (
"context"
"fmt"
"strconv"
"time"

"github.com/alecthomas/units"
Expand Down Expand Up @@ -56,6 +57,7 @@ type storeConfig struct {
httpConfig httpConfig
indexCacheSizeBytes units.Base2Bytes
chunkPoolSize units.Base2Bytes
seriesBatchSize int
maxSampleCount uint64
maxTouchedSeriesCount uint64
maxDownloadedBytes units.Base2Bytes
Expand Down Expand Up @@ -129,6 +131,9 @@ func (sc *storeConfig) registerFlag(cmd extkingpin.FlagClause) {
cmd.Flag("block-meta-fetch-concurrency", "Number of goroutines to use when fetching block metadata from object storage.").
Default("32").IntVar(&sc.blockMetaFetchConcurrency)

cmd.Flag("debug.series-batch-size", "The batch size when fetching series from TSDB blocks. Setting the number too high can lead to slower retrieval, while setting it too low can lead to throttling caused by too many calls made to object storage.").
yeya24 marked this conversation as resolved.
Show resolved Hide resolved
Hidden().Default(strconv.Itoa(store.SeriesBatchSize)).IntVar(&sc.seriesBatchSize)

sc.filterConf = &store.FilterConfig{}

cmd.Flag("min-time", "Start of time range limit to serve. Thanos Store will serve only metrics, which happened later than this value. Option can be a constant time in RFC3339 format or time duration relative to current time, such as -1d or 2h45m. Valid duration units are ms, s, m, h, d, w, y.").
Expand Down Expand Up @@ -340,6 +345,7 @@ func runStore(
store.WithChunkPool(chunkPool),
store.WithFilterConfig(conf.filterConf),
store.WithChunkHashCalculation(true),
store.WithSeriesBatchSize(conf.seriesBatchSize),
}

if conf.debugLogging {
Expand Down
Loading