Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ketama quorum #5910

Merged
merged 7 commits into from
Dec 15, 2022
Merged

Fix ketama quorum #5910

merged 7 commits into from
Dec 15, 2022

Commits on Nov 24, 2022

  1. Fix quorum calculation for Ketama hashring 

    The quorum calculation is currently broken when using the Ketama
hashring. The reasons are explained in detail in issue
thanos-io#5784.

This commit fixes quorum calculation by tracking successfull writes
for each individual time-series inside a remote-write request.

The commit also removes the replicate() method inside the Handler
and moves the entire logic of fanning out and calculating success
into the fanoutForward() method.

Signed-off-by: Filip Petkovski <[email protected]>
    @fpetkovski
    fpetkovski committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    572bddf View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2022

  1. Fix error propagation 

    Signed-off-by: fpetkovski <[email protected]>
    @fpetkovski
    fpetkovski committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    b002700 View commit details
    Browse the repository at this point in the history

  2. Fix writer errors 

    Signed-off-by: fpetkovski <[email protected]>
    @fpetkovski
    fpetkovski committed Nov 26, 2022
    Configuration menu
    Copy the full SHA
    d83a624 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2022

  1. Separate write from replication errors 

    Signed-off-by: fpetkovski <[email protected]>
    @fpetkovski
    fpetkovski committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    a08ba98 View commit details
    Browse the repository at this point in the history

  2. Add back replication metric 

    Signed-off-by: Filip Petkovski <[email protected]>
    @fpetkovski
    fpetkovski committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    f4e8ff0 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2022

  1. Address PR comments 

    Signed-off-by: Filip Petkovski <[email protected]>
    @fpetkovski
    fpetkovski committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    fb91d51 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2022

  1. Address code review comments 

    Signed-off-by: Filip Petkovski <[email protected]>
    @fpetkovski
    fpetkovski committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    4c870b4 View commit details
    Browse the repository at this point in the history