Proxy: Only generate debug messages in debug mode #6228
Merged
Commits on Mar 22, 2023
-
Proxy: Only generate debug messages in debug mode
In debug mode we log information about which endpoints we skip and query, including the labels of each endpoint. These debug messages, can use significant memory, especially in larger setups with larger number of labelsets. Previously we would generate the debug messages, even when not in debug mode. With commit, we only generate the debug messages when debug logging is enabled. This fixes: thanos-io#6198 Signed-off-by: Jacob Baungard Hansen <[email protected]>
-
- Consistent variable naming - Also do conditional debug logging generation in: `LabelNames()` and `LabelValues` - Use builder pattern for additional variables Signed-off-by: Jacob Baungard Hansen <[email protected]>
-
Signed-off-by: Jacob Baungard Hansen <[email protected]>
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.