-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: Update busybox versions and cron #6237
Conversation
Signed-off-by: Matej Gera <[email protected]>
@matej-g I would like to challenge this "automated manual" update of the https://quay.io/prometheus/busybox image tags. I did some quick investigation in the Prometheus repo and they don't have a similar flow. Do we have a good reason for doing this in Thanos? Was there ever an issue which this flow solved? |
It breaks e2e tests as the old images tags seems to be removed, see for example the failures here: #6228 |
@jacobbaungard if we used the |
Hm seems like we're blocked on #6236 as well. |
@douglascamata can we first fix current way, so at least all pending PRs (and release) are unblocked? If you'd like to learn more about the history of the issue, feel free to take a look at #4949. |
@matej-g 100%. Let's unblock all the PRs 🚀 |
@matej-g @fpetkovski shall we merge this? 🙏 |
And so it shall be merged 🚢 |
Thanks, everyone! 🙇 |
Changes
Manually update busybox versions.
Also make the cronjob more frequent (every hour), since in case of change we might have to wait up to a day before we catch the change, causing CI failures etc.