Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate warnings from instant queries #7286

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

fpetkovski
Copy link
Contributor

@fpetkovski fpetkovski commented Apr 18, 2024

Warnings from remote instant queries get turned into errors, which is a bug. It should be up to the root client to decide whether warnings should be show as such, or converted to errors.

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

  • Propagate warnings from remotely executed instant queries.

Verification

Added a unit test and also verified locally.

Warnings from remote instant queries get turned into errors, which
is a bug. It should be up to the root client to decide whether warnings
should be show as such, or converted to errors.

Signed-off-by: Filip Petkovski <[email protected]>
Signed-off-by: Filip Petkovski <[email protected]>
Copy link
Contributor

@MichaHoffmann MichaHoffmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fpetkovski fpetkovski merged commit 6582c81 into thanos-io:main Apr 18, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants