Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

objstore: do not set last successful time metric before 1st upload #921

Merged
merged 1 commit into from
Mar 14, 2019
Merged

objstore: do not set last successful time metric before 1st upload #921

merged 1 commit into from
Mar 14, 2019

Commits on Mar 13, 2019

  1. objstore: do not set last successful time metric before 1st upload 

    Convert lastSuccessfullUploadTime into a GaugeVec with one dimension:
bucket, which makes client_golang *not* make that metric unless at least
one value has appeared.

This is better for users since Grafana will show that last upload has
been 49+ years ago instead of N/A when no uploads had happened before.

Fixes thanos-io#886.
    @GiedriusS
    GiedriusS committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    3712d88 View commit details
    Browse the repository at this point in the history