-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some Docs suggestions #114
Conversation
Changed some grammar
minor grammar change
minor grammar changes
minor grammar changes
Minor grammar changes
minor grammar changes
minor grammar changes
typo...
Minor grammar changes
minor grammar change
Minor grammar changes
Minor grammar changes
Codecov Report
@@ Coverage Diff @@
## master #114 +/- ##
=======================================
Coverage 88.73% 88.73%
=======================================
Files 28 28
Lines 1563 1563
=======================================
Hits 1387 1387
Misses 176 176 Continue to review full report at Codecov.
|
Thanks. |
@MasonProtter Hi Mason, could you help here? |
That is a good idea. I am a native English speaker, but, my English isn't always the best :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly good, here are some nitpicks of mine. Thanks for taking the time to do this @caseykneale!
Co-authored-by: Mason Protter <[email protected]>
Co-authored-by: Mason Protter <[email protected]>
Co-authored-by: Mason Protter <[email protected]>
Co-authored-by: Mason Protter <[email protected]>
Co-authored-by: Mason Protter <[email protected]>
Co-authored-by: Mason Protter <[email protected]>
Co-authored-by: Mason Protter <[email protected]>
Co-authored-by: Mason Protter <[email protected]>
Co-authored-by: Mason Protter <[email protected]>
Co-authored-by: Mason Protter <[email protected]>
Co-authored-by: Mason Protter <[email protected]>
Co-authored-by: Mason Protter <[email protected]>
Co-authored-by: Mason Protter <[email protected]>
Co-authored-by: Mason Protter <[email protected]>
Co-authored-by: Mason Protter <[email protected]>
Co-authored-by: Mason Protter <[email protected]>
Rolling back a grammar change
No problem I had some free time come up and thought I'd put it to use. I agree with pretty much all of your knit-picks. |
Bigs thanks to @caseykneale and @MasonProtter ! |
I am not in a hurry, just wanted to help :). Let me know if there's anything else I can do, |
There are 29 commits, do you mind if I squash them? @caseykneale |
I think maybe this should be reverted and squashed. That was a LOT of commits |
I didn't operate it correctly, maybe you make a PR again? |
Hi I am a Julia programmer who recently started learning functional programming. I think your package is really cool! I made some changes to the documentation. You do not have to accept them, but they, improve some of the grammar.
I feel your original documentation was good, but others may struggle to read some small parts in it.