Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Docs suggestions #114

Merged
merged 29 commits into from
Mar 19, 2021
Merged

Some Docs suggestions #114

merged 29 commits into from
Mar 19, 2021

Conversation

caseykneale
Copy link
Contributor

Hi I am a Julia programmer who recently started learning functional programming. I think your package is really cool! I made some changes to the documentation. You do not have to accept them, but they, improve some of the grammar.

I feel your original documentation was good, but others may struggle to read some small parts in it.

Changed some grammar
minor grammar change
minor grammar changes
minor grammar changes
Minor grammar changes
minor grammar changes
minor grammar changes
Minor grammar changes
minor grammar change
Minor grammar changes
Minor grammar changes
@codecov
Copy link

codecov bot commented Mar 14, 2021

Codecov Report

Merging #114 (866e3bf) into master (6084bf7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #114   +/-   ##
=======================================
  Coverage   88.73%   88.73%           
=======================================
  Files          28       28           
  Lines        1563     1563           
=======================================
  Hits         1387     1387           
  Misses        176      176           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6084bf7...866e3bf. Read the comment docs.

@thautwarm
Copy link
Owner

Thanks.
I'm not a native English speaker, and as your PR is a bit large, I'd ask others to help me with review.

@thautwarm
Copy link
Owner

@MasonProtter Hi Mason, could you help here?

@caseykneale
Copy link
Contributor Author

That is a good idea. I am a native English speaker, but, my English isn't always the best :)

Copy link
Contributor

@MasonProtter MasonProtter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good, here are some nitpicks of mine. Thanks for taking the time to do this @caseykneale!

docs/benchmark.md Outdated Show resolved Hide resolved
docs/benchmark.md Outdated Show resolved Hide resolved
docs/benchmark.md Show resolved Hide resolved
docs/benchmark.md Outdated Show resolved Hide resolved
docs/syntax/adt.md Outdated Show resolved Hide resolved
docs/tutorials/query-lang.md Outdated Show resolved Hide resolved
docs/tutorials/query-lang.md Outdated Show resolved Hide resolved
docs/tutorials/query-lang.md Outdated Show resolved Hide resolved
docs/what.md Outdated Show resolved Hide resolved
docs/what.md Outdated Show resolved Hide resolved
caseykneale and others added 13 commits March 15, 2021 17:35
Co-authored-by: Mason Protter <[email protected]>
Co-authored-by: Mason Protter <[email protected]>
Co-authored-by: Mason Protter <[email protected]>
Co-authored-by: Mason Protter <[email protected]>
Co-authored-by: Mason Protter <[email protected]>
Co-authored-by: Mason Protter <[email protected]>
Co-authored-by: Mason Protter <[email protected]>
Co-authored-by: Mason Protter <[email protected]>
Co-authored-by: Mason Protter <[email protected]>
Co-authored-by: Mason Protter <[email protected]>
caseykneale and others added 4 commits March 15, 2021 17:40
Rolling back a grammar change
@caseykneale
Copy link
Contributor Author

No problem I had some free time come up and thought I'd put it to use.

I agree with pretty much all of your knit-picks.

@thautwarm
Copy link
Owner

Bigs thanks to @caseykneale and @MasonProtter !
Once Mason approve the PR I will merge it.

@caseykneale
Copy link
Contributor Author

I am not in a hurry, just wanted to help :). Let me know if there's anything else I can do,

@thautwarm
Copy link
Owner

There are 29 commits, do you mind if I squash them? @caseykneale

@thautwarm thautwarm merged commit b135efc into thautwarm:master Mar 19, 2021
@MasonProtter
Copy link
Contributor

I think maybe this should be reverted and squashed. That was a LOT of commits

@thautwarm
Copy link
Owner

I didn't operate it correctly, maybe you make a PR again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants