Add Example to Reference Pattern Docs #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thautwarm
requested changes
May 18, 2021
Codecov Report
@@ Coverage Diff @@
## master #122 +/- ##
=======================================
Coverage 81.93% 81.93%
=======================================
Files 26 26
Lines 1522 1522
=======================================
Hits 1247 1247
Misses 275 275 Continue to review full report at Codecov.
|
thautwarm
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I really like MLStyle and the pattern matching it provides. I ran into an issue today where it was difficult to figure out how to match on the abstract value of an Int16 and Int64. I thought adding some extra detail to the docs might help out anyone else in this position. I also tried to sum up the some of the discussion on pattern matching and equality that happened #62 . Let me know what you think!