avoid "type DataType has no field size" #148
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to avoid the issue described #147 that breaks this package on julia 1.9-DEV.
The julia change that triggers this is JuliaLang/julia#47170.
Looking at the changes in that PR I first tried to simply replace
ty.size
withCore.sizeof(ty)
, but that gave an error: "Type Symbol does not have a definite size."Since
I figured we could just use the short circuiting to avoid calling sizeof for Symbol by switching the order of the &&.
There may be a better way to fix this however.