Add Fixed Supported Language File 🌐 #123
Conversation
GrantBirki
added
bug
👋 Thanks for opening a pull request!If you are new, please check out the trimmed down summary of our deployment process below:
|
|
.deploy to development |
Deployment TriggeredGrantBirki, started a branch deployment 🚀
You can watch the progress here 🔗 |
Deployment Results
Successfully deployed branch add-supported-languages
|
Deploying with
|
| Latest commit: |
af96ef3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8066cf11.tarkov-dev.pages.dev |
|
.deploy |
Deployment TriggeredGrantBirki, started a branch deployment 🚀
You can watch the progress here 🔗 |
Deployment Results
Successfully deployed branch add-supported-languages
|
Add Fixed Supported Language File 🌐
This pull request adds a fixed language file which is used to define an explicit list of supported languages. As we have new languages, we can add them to this file which is checked into GitHub.
The reason for adding this is because this website is a "client" of the API. The API only has so many supported languages at this time and it has users from all over the world. If a user tries to make an API call (currently, before this fix), the website would use their locale in the API query. If an unsupported language was used, the whole website would fall apart.
Updating Language Codes
The screenshot below shows where the latest supported LanguageCodes can be found
LanguageCode enum in public graphql docs:
We can update the
supported-languages.jsonfile with any languages as they become supported and appear in our schema