Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pi40.json #1721

Merged
merged 1 commit into from
Mar 24, 2023
Merged

Update pi40.json #1721

merged 1 commit into from
Mar 24, 2023

Conversation

ziptyze
Copy link
Contributor

@ziptyze ziptyze commented Mar 1, 2023 •
edited by Xelus22
Loading

Edit pi40 .json to include new layout options

Description

QMK Pull Request

qmk/qmk_firmware#20066

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@yiancar
Copy link
Collaborator

yiancar commented Mar 5, 2023

Please ping us when QMK has been merged.

@yiancar yiancar closed this Mar 5, 2023
@ziptyze
Copy link
Contributor Author

ziptyze commented Mar 23, 2023

fully merged now
https://github.com/qmk/qmk_firmware/tree/master/keyboards/1upkeyboards/pi40

@Xelus22 Xelus22 reopened this Mar 24, 2023
@Xelus22 Xelus22 merged commit 70d1cbf into the-via:master Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xelus22 Xelus22 Xelus22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ziptyze @yiancar @Xelus22