Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VIA support for Keychron Q9 Plus #2022

Merged
merged 1 commit into from
Sep 24, 2023
Merged

Add VIA support for Keychron Q9 Plus #2022

merged 1 commit into from
Sep 24, 2023

Conversation

KeychronMacro
Copy link
Contributor

@KeychronMacro KeychronMacro commented Sep 22, 2023 •
edited
Loading

Add VIA support for Keychron Q9 Plus and request for a review, thanks!

Description

  • Added ansi_encoder.json into v3/keychron/q9_plus.

QMK Pull Request

qmk/qmk_firmware#21399

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@Xelus22
Copy link
Collaborator

Xelus22 commented Sep 23, 2023

Please add QMK pr

@KeychronMacro
Copy link
Contributor Author

Please add QMK pr

Hi, added, thanks!

@Xelus22 Xelus22 merged commit f639114 into the-via:master Sep 24, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xelus22 Xelus22 Xelus22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KeychronMacro @Xelus22 @galican