Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create sodium62.json #2212

Merged
merged 2 commits into from
Apr 28, 2024
Merged

Create sodium62.json #2212

merged 2 commits into from
Apr 28, 2024

Conversation

Na-Cly
Copy link
Contributor

@Na-Cly Na-Cly commented Mar 28, 2024

Description

QMK Pull Request

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@Cipulot
Copy link
Collaborator

Cipulot commented Mar 29, 2024

@Na-Cly 2 things:

  • add QMK PR merge link as per requirements of the PR
  • apply formatting to the json

@Cipulot Cipulot added the needs work The PR needs fixes/ things need to be addressed label Mar 30, 2024
@Na-Cly
Copy link
Contributor Author

Na-Cly commented Apr 3, 2024

qmk/qmk_firmware#23063
qmk/qmk_firmware#17345

What formatting did you want in the json? It's formatted correctly in my vscode.

Cipulot
Cipulot requested changes Apr 3, 2024
View reviewed changes
v3/sodium62/sodium62.json Outdated Show resolved Hide resolved
@Na-Cly
Copy link
Contributor Author

Na-Cly commented Apr 3, 2024

Thank you.

@Na-Cly Na-Cly requested a review from Cipulot April 21, 2024 22:39
@Na-Cly
Copy link
Contributor Author

Na-Cly commented Apr 27, 2024

Can I get this merged?

@Cipulot Cipulot merged commit 21b309c into the-via:master Apr 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cipulot Cipulot Cipulot approved these changes

Assignees
No one assigned
Labels
needs work The PR needs fixes/ things need to be addressed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Na-Cly @Cipulot