-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add reauthorizeDataAccess method to LoginManager #204
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks generally really good, I'll kick off CI, but I need to understand RCT_REMAP_METHOD prior to merge
|
You've got to love it when something tells you there's an issue, but no what the actual issue is. Maybe you need to tweak your prettier config? It's fixed in 8b8e9fc. |
I think local prettier integrations (like the one in VScode at least, which you indicate you are using?) do look at the local .prettierrc and do tell you - either way because of the way prettier is, you just need to run it and that's that - but this is something that would be best in a pre-commit hook yeah - no reason to wait till it hits CI to see it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks really good now, happy to approve + merge + release in just a moment, and though it doesn't matter now it appears that the alternative RCT_NNNNN method was just in case there was a symbol collision exporting the method? Interesting - makes sense I guess, just never seen it needed in any of the other repos I've worked on. Learn something every day...
## [7.2.0](v7.1.0...v7.2.0) (2022-02-21) ### Features * Add reauthorizeDataAccess method to LoginManager ([#204](#204)) ([4aa7ff6](4aa7ff6))
🎉 This PR is included in version 7.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This pull request replicates the functionality added in facebookarchive/react-native-fbsdk#720 in order to facilitate the requesting of data access permissions when they have expired. The native Facebook SDK exposes a method on the LoginManager class (
reauthorizeDataAccess
) that the changes in this pull request exposes to the JS layer.Test Plan:
We've modified the example app to call the new method. We've also tested this with a separate app to verify the code is behaving as expected.