feat(ios): adopt facebook-ios-sdk 17.1.0 #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- yarn2+ is now used - touch empty yarn.lock during construction to make example distinct - add react-native-fbsdk-next using new git dep syntax - git is initialized by default now, avoid that - npx now prompts unless you specify for it to go unattended mode - facebook ContentProvider on android is an instant crash now for some reason
of note: - typescript updated, and that updated the plugin's built artifact - semantic release stuff all moved across majors, deserves a close watch during release
done separately in case it changed the built artifact in some way
|
Fixed the various deprecation and lint things I saw while examining the CI output |
- implement new invalidate method - keep previous onCatalystInstanceDestroy method since it called super
- was calling varargs method with null which was ambiguous - call was annotated as argument optional, so remove null to resolve
mikehardy
added
the
pending-merge
mikehardy
removed
the
pending-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Investigate the diff between facebook-ios-sdk 17.0.x and 17.1.x, appears fine, and appears to work fine in testing
Note: there is a 17.2.0 apparently already cooking per their changelog but it isn't on cocoapods yet so I couldn't fetch it
I allow the facebook-ios-sdk version to slip for patch versions now but they have a warning about Swift/Obj-C compat on their repo indicating that minor versions may break compiles, so I couldn't let the semver range slip minors. They have broken us before 🤷
Fixes #555