-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added a schema lock file to tdbm #171
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kharhamel
force-pushed
the
lockFile
branch
3 times, most recently
from
September 6, 2019 15:09
b8d7ef9
to
fb45e33
Compare
Kharhamel
changed the title
WIP: added a schema lock file to tdbm
added a schema lock file to tdbm
Sep 6, 2019
Kharhamel
force-pushed
the
lockFile
branch
2 times, most recently
from
September 24, 2019 13:42
25d7e72
to
b810044
Compare
moufmouf
reviewed
Sep 24, 2019
moufmouf
requested changes
Sep 24, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty cool.
Only one small comment about the location of the getDefaultLockFilePath
Kharhamel
force-pushed
the
lockFile
branch
4 times, most recently
from
September 24, 2019 14:44
3b833c2
to
61bc87c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.