Skip to content

Commit

Permalink
fix: auto set vmid when creating host from Foreman API (#312)
Browse files Browse the repository at this point in the history
fixes #254
  • Loading branch information
Manisha15 authored Feb 29, 2024
1 parent 057cf08 commit edc4a0c
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions app/models/foreman_fog_proxmox/proxmox_vm_commands.rb
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,9 @@ def start_on_boot(vm, args)
end

def create_vm(args = {})
vmid = args[:vmid].to_i
type = args[:type]
node = client.nodes.get(args[:node_id])
vmid = node.servers.next_id.to_i if vmid < 1
vmid = args[:vmid] = assign_vmid(args[:vmid].to_i, node)
raise ::Foreman::Exception, format(N_('invalid vmid=%<vmid>s'), vmid: vmid) unless node.servers.id_valid?(vmid)

image_id = args[:image_id]
Expand All @@ -55,6 +54,10 @@ def create_vm(args = {})
raise e
end

def assign_vmid(vmid, node)
vmid < 1 ? node.servers.next_id : vmid
end

def compute_clone_attributes(args, container, type)
args = parse_cloudinit_config(args) if args[:user_data]
parsed_args = parse_typed_vm(args, type)
Expand Down

0 comments on commit edc4a0c

Please sign in to comment.