Add the ability to modify metrics.conf with a jolokia metrics policy location file #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Feb 13, 2024
|
|
||
| if $jolokia_metrics_policy != undef { | ||
| file { '/etc/puppetlabs/puppetserver/jolokia-access.xml' : | ||
| ensure => file, |
There was a problem hiding this comment.
Does it make sense to ensure it's absent when $jolokia_metrics_policy is undef?
There was a problem hiding this comment.
Sorry for the super late reply, but I'd argue the absence of $jolokia_metrics_policy should not dictate enforcing the absence of the file.
I could see ensuring jolokia-access.xml as absent if $jolokia_metrics_policy == absent, but not undef.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To expose Jolokia metrics,
metrics.confexpects ajolokia-access.xmlfile path, and a corresponding jolokia-access.xml file. Currently, metrics.conf has the boilerplate code commented out. This PR allows the contents of jolokia-access.xml to be passed as a parameter. If it's passed, write jolokia-access.xml in the default location and uncomment the line in metrics.conf.