✨ Add <!doctype html> to html serialization #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without a proper doctype, html will load in quirks mode, so this adds a doctype declaration to force the output to be HTML5 for every single HTML response. Theoretically, this sets up a situation where you want to serve a doc in quirks mode, but can't. 1) this will never happen 2) when it does, we can figure out how to deal with it at that point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Without a proper doctype, html will load in quirks mode.
Approach
This adds a doctype declaration to force the output to be HTML5 for every single HTML response.
Theoretically, this sets up a situation where you want to serve a doc in quirks mode, but can't.