Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Quire! Please complete the form below to submit your pull request for review.
For the Title of this pull request, please use the format "Type/Issue-#: Brief description." For Type, the options are Fix, Feature, Docs, or Chore. Issue-# is only needed if this pull request addresses an existing issue.
Before submitting your PR, make sure that you can run the following commands:
quire preview
,quire build
,quire pdf
, andquire epub
. If any of those core quire commands throw errors/yield unexpected behavior, we will NOT review the PR!Checklist
Please put an
X
within the brackets that apply[X]
.I have read the CONTRIBUTING.md file
I have made my changes in a new branch and not directly in the main branch
This pull request is ready for final review by the Quire team
Is this pull request related to an open issue? If so, what is the issue number?
Please briefly describe the goal of this pull request and how it may impact Quire's functionality.
Developing locally I found that when
order
is not set or has many duplicate values, default sort was not stable.I think Hugo's default sort fallbacks and the way it uses
weight
is significantly different from the current behavior. I created auseCustomSort
config key to implement a more flexible TOC sort based on title string.At the very least, I propose you
getAllSorted
first in order to ensure that order is not different between builds whenorder
is missing.Please describe the changes you made, and call out any details you think are particularly relevant for the Quire team to note in their review.
Does this pull request necessitate changes to Quire's documentation?
Include screenshots of before/after if applicable.
Additional Comments