Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial commit of v2 migration #85

Merged
merged 16 commits into from
Nov 17, 2018
Merged

initial commit of v2 migration #85

merged 16 commits into from
Nov 17, 2018

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Jun 9, 2018 •
edited
Loading

resolves #82

Changes

  1. Upgraded site according to Gatsby v2 Migration Guide
  2. Made all components use const instead of class where appropriate

TODO

  1. move SocialLinksService to the <Footer> component makes more sense to keep the state at the app level, rather than at the component level
  2. remove gatsby-link?
  3. commons.css - see [Gatsby v2] commons.css 404 network error using gatsby develop gatsbyjs/gatsby#5825 - just waiting for next release!
  4. Unit testing - preprocess with .babelrc? - had to move to jest.config.js
  5. Unit testing - missing pages.json - see [Gatsby v2] Jest unit testing and configuration for Gatsby gatsbyjs/gatsby#5824
  6. .eslintrc needed ? - yes, for local linting
  7. CSS preloading observations
  8. Upgrade to latest gatsby to validate pages.json fix - maybe?
  9. Gatsby <Link> breaking integration tests? Would also address unit test fails when component under test imoports a <Link> component from Gatsby #34
  10. Ran into this issue after upgrading to 2.0.0-beta.18
  11. Ran into this issue after upgrading to 2.0.0-beta.61
  12. Build should pass with initial (or greater!) code coverage levels
  13. Official v2 release - new issue with unit testing :( - will be handled in Finish upgrade to Gastby v2 #92

screen shot 2018-06-09 at 1 41 28 pm

@thescientist13 thescientist13 added the chore build stuff, deploy stuff, etc etc label Jun 9, 2018
@thescientist13 thescientist13 self-assigned this Jun 9, 2018
@thescientist13 thescientist13 mentioned this pull request Jun 30, 2018
Closed
@thescientist13 thescientist13 mentioned this pull request Jul 28, 2018
Closed
thescientist13
thescientist13 commented Jul 28, 2018
View reviewed changes
Copy link
Member Author

@thescientist13 thescientist13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can go whenever I suppose, or could wait until the final release of v2.

@thescientist13
Copy link
Member Author

Maybe I should just get this in and make a new bug issue for tracking the final version bump?

@thescientist13 thescientist13 force-pushed the technical/issue-82-gatsby-v2-upgrade branch from 8aa0583 to 5a34a76 Compare November 17, 2018 20:05
@thescientist13
Copy link
Member Author

test this please

@thescientist13 thescientist13 merged commit 6dead08 into master Nov 17, 2018
@thescientist13 thescientist13 deleted the technical/issue-82-gatsby-v2-upgrade branch November 17, 2018 20:20
thescientist13 added a commit that referenced this pull request Nov 17, 2018
@thescientist13
Revert "initial commit of v2 migration (#85)"
896cba0 
This reverts commit 6dead08.
@thescientist13 thescientist13 mentioned this pull request Nov 17, 2018
Merged
thescientist13 added a commit that referenced this pull request Nov 17, 2018
@thescientist13
Revert "initial commit of v2 migration (#85)" (#94)
4696228 
This reverts commit 6dead08.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thescientist13 thescientist13

Labels
chore build stuff, deploy stuff, etc etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to Gatsby v2
1 participant
@thescientist13