Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Http Channel does not handle 204 response gracefully #889

Closed
jamime opened this issue Mar 15, 2018 · 1 comment
Closed

Http Channel does not handle 204 response gracefully #889

jamime opened this issue Mar 15, 2018 · 1 comment

Comments

@jamime
Copy link

jamime commented Mar 15, 2018

Expected behavior

The remote.html runner should report a success when it receives a 204 from intern

Current behavior

Errors are reported in the browser window such as Error sending testStart/testEnd. The results are reported to the intern process correctly.

Possible solution

When lib/middleware/post.ts returns a 204 we should not try to parse the empty body.

return response.json<any[]>();

Steps to reproduce (for bugs)

You need to disable the websocket connection by setting "socketPort": false in your config.

Environment

Intern version: 4.1.5
Node version: v9.7.1
NPM version: 5.6.0
Browser version: Chrome 65

Additional information

whatwg/fetch#113

jason0x43 added a commit that referenced this issue Mar 19, 2018
@jason0x43
Copy link
Member

This is included in Intern 4.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants