We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The remote.html runner should report a success when it receives a 204 from intern
remote.html
Errors are reported in the browser window such as Error sending testStart/testEnd. The results are reported to the intern process correctly.
When lib/middleware/post.ts returns a 204 we should not try to parse the empty body.
lib/middleware/post.ts
204
intern/src/lib/channels/Http.ts
Line 79 in f56177f
You need to disable the websocket connection by setting "socketPort": false in your config.
"socketPort": false
Intern version: 4.1.5 Node version: v9.7.1 NPM version: 5.6.0 Browser version: Chrome 65
whatwg/fetch#113
The text was updated successfully, but these errors were encountered:
Handle 204 responses in Http channel
679a903
references #889
This is included in Intern 4.2.0.
Sorry, something went wrong.
No branches or pull requests
Expected behavior
The
remote.html
runner should report a success when it receives a 204 from internCurrent behavior
Errors are reported in the browser window such as Error sending testStart/testEnd. The results are reported to the intern process correctly.
Possible solution
When
lib/middleware/post.ts
returns a204
we should not try to parse the empty body.intern/src/lib/channels/Http.ts
Line 79 in f56177f
Steps to reproduce (for bugs)
You need to disable the websocket connection by setting
"socketPort": false
in your config.Environment
Intern version: 4.1.5
Node version: v9.7.1
NPM version: 5.6.0
Browser version: Chrome 65
Additional information
whatwg/fetch#113
The text was updated successfully, but these errors were encountered: