-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor clean_obs_names #532
Merged
WeilerP
merged 11 commits into
theislab:develop
from
WeilerP:feat/refactor_clean_obs_names
Jul 14, 2021
Merged
Refactor clean_obs_names #532
WeilerP
merged 11 commits into
theislab:develop
from
WeilerP:feat/refactor_clean_obs_names
Jul 14, 2021
Commits on Jul 13, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 9e04132 - Browse repository at this point
Copy the full SHA 9e04132View commit details -
Checking if all observation names are of equal length can entirely be done using Pandas functionality. This looks slightly cleaner.
Configuration menu - View commit details
-
Copy full SHA for d5fe462 - Browse repository at this point
Copy the full SHA d5fe462View commit details -
Rename * `ID_length` to `id_length` to consistently use lower case letters for variables. * `newIDs` and `newID` to `new_obs_names` and `new_obs_name` to have clearer names and consistently use lower case letters and snake case for variable names. * `id` to `new_obs_name` to use more informative name.
Configuration menu - View commit details
-
Copy full SHA for f19f58e - Browse repository at this point
Copy the full SHA f19f58eView commit details -
Refactor code to not rely on variable `names` but use adata.obs_names directly.
Configuration menu - View commit details
-
Copy full SHA for 1b79dd4 - Browse repository at this point
Copy the full SHA 1b79dd4View commit details -
Configuration menu - View commit details
-
Copy full SHA for bdc706b - Browse repository at this point
Copy the full SHA bdc706bView commit details -
The argument `data` needs to be an `AnnData` object. The argument name should convey this.
Configuration menu - View commit details
-
Copy full SHA for c45bb61 - Browse repository at this point
Copy the full SHA c45bb61View commit details -
Refactor calculation of start and end position
Makes use of regex expression instead of relying on custom function.
Configuration menu - View commit details
-
Copy full SHA for a4f6e35 - Browse repository at this point
Copy the full SHA a4f6e35View commit details -
* Use regex expression to find start and end positions. * Apply to each observation using map on Pandas index.
Configuration menu - View commit details
-
Copy full SHA for c3d1b25 - Browse repository at this point
Copy the full SHA c3d1b25View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7880b11 - Browse repository at this point
Copy the full SHA 7880b11View commit details
Commits on Jul 14, 2021
-
Move `adata.obs_names_make_unique()` up to group similar parts of the code together.
Configuration menu - View commit details
-
Copy full SHA for b4bc19a - Browse repository at this point
Copy the full SHA b4bc19aView commit details -
Refactor definition of prefixes when observation names have same length.
Configuration menu - View commit details
-
Copy full SHA for d903fdb - Browse repository at this point
Copy the full SHA d903fdbView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.