Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor and generalize get_size #569

Merged
merged 3 commits into from
Jul 29, 2021
Merged

Refactor and generalize get_size #569

merged 3 commits into from
Jul 29, 2021

Commits on Jul 29, 2021

  1. Rename layer to modality 

    Rename argument `layer` to `modality` in `get_size`. This unifies naming
convention for the argument across the code base and prepares
generalizing `get_size` to arbitrary modalities.
    @WeilerP
    WeilerP committed Jul 29, 2021
    Configuration menu
    Copy the full SHA
    af0006a View commit details
    Browse the repository at this point in the history

  2. Generalize get_size to arbitrary modality 

    This allows calculating the size per observation for any modality, from
`adata.X`, `adata.layers` or `adata.obsm`.
    @WeilerP
    WeilerP committed Jul 29, 2021
    Configuration menu
    Copy the full SHA
    169b6fc View commit details
    Browse the repository at this point in the history

  3. Update docstrings

    @WeilerP
    WeilerP committed Jul 29, 2021
    Configuration menu
    Copy the full SHA
    7550f05 View commit details
    Browse the repository at this point in the history