Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Selenium dependency #20

Open
thelabcat opened this issue Aug 12, 2024 · 1 comment
Open

Remove Selenium dependency #20

thelabcat opened this issue Aug 12, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@thelabcat
Copy link
Owner

Selenium may not be needed as this module can log in without it.
@thelabcat thelabcat added the enhancement New feature or request label Aug 12, 2024
thelabcat added a commit that referenced this issue Aug 12, 2024
@thelabcat
Added password hash calculator for #20
dd64ac6
thelabcat added a commit that referenced this issue Aug 16, 2024
@thelabcat
Removed js2py usage (see #20)
4b83790 
Js2py is broken and cannot be used
@thelabcat
Copy link
Owner Author

thelabcat commented Aug 16, 2024 •
edited
Loading

Because of PiotrDabkowski/Js2Py#317 I cannot use the exact password hash calculator that RumblePy used. I may find a pure Python alternative to the JavaScript function used in the future. However, I'm concerned about the maintainability of this headless plan.

thelabcat added a commit that referenced this issue Aug 16, 2024
@thelabcat
Removed unused imports (see #20)
1990ef6
@thelabcat thelabcat mentioned this issue Aug 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thelabcat